> On June 16, 2014, 5:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java, > > line 139 > > <https://reviews.apache.org/r/17720/diff/13/?file=608483#file608483line139> > > > > This can be removed and the similar method you added for the HCat+HA > > patch can be used instead.
actually both introduced for different purposes. isHighlyAvailableMode() indicate whether server starts in HA mode or not (ZKJobsConcurrency used or not), MultipleServerRunning indicate whether # of servers running > 1 or not at each moment (even in HA mode). in HCat, we enable dependency table purge when start in HA mode (regardless of # of servers) thus, using isHighlyAvailableMode(). in SLA, even in HA mode, when only one server is running, we avoid using zk lock, thus using MultipleServerRunning(). so I believe both needed. > On June 16, 2014, 5:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java, line 290 > > <https://reviews.apache.org/r/17720/diff/13/?file=608485#file608485line290> > > > > What happens if multiple threads in the same Oozie server try to call > > acquireLock(), isLocked(), and/or releaseLock() concurrently? yes, to that end, we do synchronized (slaCalc) before occurence of slaCalc.acquireLock(). let me check again if there is no overlook - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17720/#review45770 ----------------------------------------------------------- On June 13, 2014, 7:49 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17720/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 7:49 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1678 > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1678 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/WorkflowJobBean.java 0b8ee96 > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 436b999 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > d2331e8 > > core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > 319aea0 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > cddeaf7 > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e3b115f > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > 79d11ed > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 9156a27 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > e7d42e9 > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java > 7b4e177 > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java > 1510daf > > core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java > 1f7cb4d > core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 27c97e6 > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 611b74c > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 86c2d32 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java > 00fb677 > > core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java > 2e170a4 > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java > 9e0f03b > > core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java > ea36720 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > PRE-CREATION > core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 9270aa2 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 9a16722 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > 3ce86ab > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 40376a5 > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > cd2fbae > core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 > > core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 3a9e72e > core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 > core/src/test/resources/coord-action-sla.xml 4893c61 > > Diff: https://reviews.apache.org/r/17720/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
