[ 
https://issues.apache.org/jira/browse/OOZIE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170702#comment-14170702
 ] 

Azrael commented on OOZIE-1890:
-------------------------------

The patch will show debug messages: 
# overriding with oozie-site
{code}
Overriding configuration with oozie-site, [oozie.service.JPAService.jdbc.url]
Overriding configuration with oozie-site, [oozie.service.JPAService.jdbc.driver]
{code}
# custom configuration: not defined in oozie-default but defined in oozie-site
{code}
Invalid configuration defined, 
[oozie.service.XLogStreamingService.actionname.enable]
{code}
# using code default: not in oozie-default, oozie-site 
{code}
Configuration property 
[oozie.service.ShareLibService.temp.sharelib.retention.days] not found, use 
given value [7]
Configuration property [oozie.subworkflow.classpath.inheritance] not found, use 
given value [false]
{code}

For the schema extensions, {{SchemaService}} uses only extensions: 
{{wf.ext.schemas}}, {{coord.ext.schemas}}, {{bundle.ext.schemas}}. I am not 
sure why it uses only ext's and design purpose so that I leave it as it is.

[~rkanter], can you review please?

> Make oozie-site empty and reconcile defaults between oozie-default and the 
> code
> -------------------------------------------------------------------------------
>
>                 Key: OOZIE-1890
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1890
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Robert Kanter
>            Assignee: Azrael
>         Attachments: OOZIE-1890.1.patch, OOZIE-1890.2.patch, 
> OOZIE-1890.3.patch
>
>
> As shwetha and puru suggested in OOZIE-1888, oozie-site vs oozie-default is a 
> point of confusion for users.  We've also had issues in the past where 
> they've had different values from each other and/or from the code's default 
> (i.e. {{conf.get(PROP_NAME, DEFAULT_VALUE)}}).
> We should make oozie-default the only source of truth by:
> # Putting all configuration properties in oozie-default.
> # Making oozie-site empty; if the user wants to change a property, they can 
> copy it out of the for-reference oozie-default.
> # Getting rid of the code defaults.  It's easy for these to be out of sync 
> with oozie-default, leading to confusion.  They aren't used anyway because 
> oozie-default should always be there (and will now have every property)
> This will require looking through all classes to make sure we're not missing 
> anything from oozie-default and also checking that we put the proper default 
> value (from all 3 sources) into oozie-default.  It may be nice to also 
> reorder the properties in oozie-default alphabetically (and also do this 
> going forward with new properties).
> Also, {{oozie.service.WorkflowAppService.system.libpath}} should be set to 
> "/user/$\{user.name\}/share/lib" (which is what OOZIE-1888 wanted to do).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to