[
https://issues.apache.org/jira/browse/OOZIE-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190969#comment-14190969
]
Robert Kanter commented on OOZIE-1890:
--------------------------------------
[~egashira], getting rid of OozieConfig was a good idea and simplifies things;
thanks for pointing that out.
On that point, I think it might currently be confusing for new devs as to how
to read config properties. We still have {{Services.get().getConf()}}, which
returns a standard {{Configuration}} object. And the new way, which is
{{ConfigurationService.get("foo")}} and similar. While we typically don't call
{{Service}} classes directly (so that they can be properly overridden),
{{ConfigurationService}} is one of the few that can't realistically be
overridden anyway, so I think that's fine.
[~seoeun25], I think we should mark {{Services.get().getConf()}} as
{{@deprecated}} and explain in the Javadoc that
{{ConfigurationService.get("foo")}} and similar should be called instead. This
way existing code written against {{Services.get().getConf()}} still works, but
it will be clear that the new way should be used; and we can eventually remove
{{Services.get().getConf()}} in Oozie 5.
> Make oozie-site empty and reconcile defaults between oozie-default and the
> code
> -------------------------------------------------------------------------------
>
> Key: OOZIE-1890
> URL: https://issues.apache.org/jira/browse/OOZIE-1890
> Project: Oozie
> Issue Type: Bug
> Components: core
> Reporter: Robert Kanter
> Assignee: Azrael
> Attachments: OOZIE-1890.1.patch, OOZIE-1890.2.patch,
> OOZIE-1890.3.patch, OOZIE-1890.4.patch, OOZIE-1890.5.patch
>
>
> As shwetha and puru suggested in OOZIE-1888, oozie-site vs oozie-default is a
> point of confusion for users. We've also had issues in the past where
> they've had different values from each other and/or from the code's default
> (i.e. {{conf.get(PROP_NAME, DEFAULT_VALUE)}}).
> We should make oozie-default the only source of truth by:
> # Putting all configuration properties in oozie-default.
> # Making oozie-site empty; if the user wants to change a property, they can
> copy it out of the for-reference oozie-default.
> # Getting rid of the code defaults. It's easy for these to be out of sync
> with oozie-default, leading to confusion. They aren't used anyway because
> oozie-default should always be there (and will now have every property)
> This will require looking through all classes to make sure we're not missing
> anything from oozie-default and also checking that we put the proper default
> value (from all 3 sources) into oozie-default. It may be nice to also
> reorder the properties in oozie-default alphabetically (and also do this
> going forward with new properties).
> Also, {{oozie.service.WorkflowAppService.system.libpath}} should be set to
> "/user/$\{user.name\}/share/lib" (which is what OOZIE-1888 wanted to do).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
