[
https://issues.apache.org/jira/browse/OOZIE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319653#comment-14319653
]
Jaydeep Vishwakarma commented on OOZIE-2129:
--------------------------------------------
[~rkanter]
My replies are inline
# Why do we get rid of {code}gar.setStartRange(startTime,
System.currentTimeMillis());{code}? IIRC, I put this in to help lower the cost
on YARN's side of looking up apps by tags. We don't have to look any earlier
than startTime.
#* As my understanding yarn do not manage any index, So doing the filter based
on time is just adding another level of complexcity. Correct me if I am wrong.
# I'm not sure we should add support for this to the Java action. While you can
run MR jobs from it, and many users do, we've typically avoided adding
MR-specific features to it to encourage users to use the MR action. The Java
action's primary purpose is to run Java programs.
#* I feel we cannot go with this assumption. I am observed many user including
me using java action for running map-reduce job. Find easy to have controls.
# I'm not sure if this is a problem, but if the user upgrades to a version of
Oozie with this patch, any actions running during the upgrade won't be able to
properly use the tags, right? Even if that's a problem, it's not likely to
occur.
#* Even now also {code}LauncherMapper{code} does not pass tag to child jobs, It
is basically a fix which will resolve the issue for all the jobs which will be
launch after applying this patch.
# In {code}LauncherMapper{code}, don't replace the {code}java.io{code} import
with {code}import java.io.;{code} we don't typically use {} for imports
#* I have checked my default settings of idea, It is brining this imports. I
will fix it.
#I'm not sure I understand how the {code}propagation-conf.xml{code} is used;
aren't all of the necessary configs appropriately set in the launcher and
action confs already?
#* I am using {code}propagation-conf.xml{code} for java action and for others
{code}mapreduce.job.tags{code} will be just duplicate value. There is no such
contract available in JavaMain to pass the conf value.
> Duplicate child jobs per instance
> ---------------------------------
>
> Key: OOZIE-2129
> URL: https://issues.apache.org/jira/browse/OOZIE-2129
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Jaydeep Vishwakarma
> Attachments: OOZIE-2129-v0.patch, OOZIE-2129-v1.patch
>
>
> OOZIE-1722 ensures that child job is killed at launcher restart. But this
> doesn't work for java actions as the tag is not passed to the child job.
> In case of coord action rerun, new workflow is created and hence new tag. So,
> it doesn't ensure old child job is killed at launcher start
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
