[ 
https://issues.apache.org/jira/browse/OOZIE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343040#comment-14343040
 ] 

Shwetha G S commented on OOZIE-2129:
------------------------------------

[~rkanter]
Ideally, users shouldn't be using java action to launch mr job, but typically 
thats how its used and its difficult to get users to migrate. Most of the users 
don't know that conf is available in action conf file and they should load that 
extra file (In fact, I was planning to add it by default as part of another 
jira as its an un-necessary extra step for user). If they don't load action 
conf, {{LauncherMainHadoopUtils.killChildYarnJobs(actionConf)}} will not work 
as tags are not set. {{Configuration.addDefaultResource(PROPAGATION_CONF_XML)}} 
will add the propagation conf as default conf and {{new Configuration()}} will 
always have the tags(loading of an extra file is not required). So, unless 
users use {{new Configuration(false)}}, tag is always passed to child job.

About using coordinator action id for tag, take the case of workflow thats 
launched from the coord action. If the child job is long running and the 
launcher job gets killed, the workflow and coord action will be killed. But the 
child job will still be running. If the user re-runs this coord action, new 
workflow will be created and hence new tag. The new launcher will not kill the 
old child job in this case. Hence the tag should be on coord action id(if 
workflow has parent).

> Duplicate child jobs per instance
> ---------------------------------
>
>                 Key: OOZIE-2129
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2129
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Jaydeep Vishwakarma
>         Attachments: OOZIE-2129-v0.patch, OOZIE-2129-v1.patch, 
> OOZIE-2129-v2.patch, OOZIE-2129-v3.patch
>
>
> OOZIE-1722 ensures that child job is killed at launcher restart. But this 
> doesn't work for java actions as the tag is not passed to the child job.
> In case of coord action rerun, new workflow is created and hence new tag. So, 
> it doesn't ensure old child job is killed at launcher start



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to