[
https://issues.apache.org/jira/browse/OOZIE-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370538#comment-14370538
]
Shwetha G S commented on OOZIE-2129:
------------------------------------
Thanks [~rkanter] for reviewing.
Few minor comments:
{code}
+ } else {
+ launcherTag = action.getId();
+ }
{code}
Not required as ActionStartXCommand handles all cases
{code}
+ if (actionConf.get("child.mapreduce.job.tags") == null) {
{code}
use variable LauncherMain.CHILD_MAPREDUCE_JOB_TAGS. Use
LauncherMain.MAPREDUCE_JOB_TAGS for 'mapreduce.job.tags'
{code}
+ public static final String CHILD_MAPREDUCE_JOB_TAGS =
"child.mapreduce.job.tags";
{code}
rename to 'oozie.mapreduce.job.tags'?
In LauncherMapper.propagateConf(), re-use the function for loading action conf
{{writeJobIdFile(idFile, jobId)}} is not required anymore??
{code}
+ arguments.add("mapreduce.job.tags=" +
actionConf.get("mapreduce.job.tags"));
{code}
Shouldn't this be actionConf.get(CHILD_MAPREDUCE_JOB_TAGS)?
> Duplicate child jobs per instance
> ---------------------------------
>
> Key: OOZIE-2129
> URL: https://issues.apache.org/jira/browse/OOZIE-2129
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Jaydeep Vishwakarma
> Attachments: OOZIE-2129-v0.patch, OOZIE-2129-v1.patch,
> OOZIE-2129-v2.patch, OOZIE-2129-v3.patch, OOZIE-2129-v4.patch,
> OOZIE-2129-v5.patch
>
>
> OOZIE-1722 ensures that child job is killed at launcher restart. But this
> doesn't work for java actions as the tag is not passed to the child job.
> In case of coord action rerun, new workflow is created and hence new tag. So,
> it doesn't ensure old child job is killed at launcher start
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
