> On June 4, 2015, 5:33 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/service/PopulatorMetricsReportingManager.java, > > line 55 > > <https://reviews.apache.org/r/34854/diff/2/?file=975102#file975102line55> > > > > Perhaps this can be merged with start. There are duplicate checks for > > METRICS_SERVER_NAME in both start & init, and they can be avoided if > > merged. Also notice that in start(), value is checked against lower case > > and in init() the check is case sensitive.
I have merged the init method with the start method > On June 4, 2015, 5:33 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/util/Instrumentation.java, line 56 > > <https://reviews.apache.org/r/34854/diff/2/?file=975103#file975103line56> > > > > Should this be in Insturmentation or InstrumentationService. > > > > I also dont see PopulatorMetricsReportingManager::stop() actually > > called unless manager's life cycle is wired up to a service > > Narayan Periwal wrote: > The life-time of the metrics reporter is the entire lifetime of the oozie > server. So, it will be stopped automatically when the oozie server stops. So, > we have no particular of stop method here. Yes, PopulatorMetricsReportingManager::stop() is not called actually. So, I have removed it from the code - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review86550 ----------------------------------------------------------- On June 4, 2015, 6:56 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 6:56 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > core/src/main/java/org/apache/oozie/service/MetricsReporter.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/Instrumentation.java 3dfb67a > core/src/main/java/org/apache/oozie/util/OozieMonitoringComponent.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 8960073 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
