----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review89557 -----------------------------------------------------------
LGTM. My only comment is the issue I reopened about the dependencies. - Robert Kanter On June 16, 2015, 10:14 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 10:14 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > 2a00a73 > core/src/main/java/org/apache/oozie/util/Instrumentation.java 4eb6386 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > 185b67e > core/src/main/resources/oozie-default.xml 4dc127e > docs/src/site/twiki/AG_Install.twiki 0ce2609 > pom.xml 4dc79c3 > webapp/pom.xml e42e219 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
