> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java, > > line 69 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350693#file1350693line69> > > > > Why 0? Why not leave it at default?
SLAThread working on slaMap will also call this. If it's waits for 5sec for each job, it will take more time. If lock is held it will process in next run on another server. > On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java, line > > 472 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350702#file1350702line472> > > > > Should be MISS as duration is missed >From doc https://oozie.apache.org/docs/4.0.0/DG_SLAMonitoring.html >>Met <-- caused by an END_MET > On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 231 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line231> > > > > Why change WAITING to FAILED? Need a test case for waiting. CoordinatorActionBean action1 = addRecordToCoordActionTable("coord-action-C@1", 1, CoordinatorAction.Status.FAILED, "coord-action-get.xml", 0); WorkflowJobBean extWf = new WorkflowJobBean(); extWf.setId(action1.getExternalId()); extWf.setEndTime(new Date(System.currentTimeMillis() - 1 * 1800 * 1000)); extWf.setStartTime(new Date(System.currentTimeMillis() - 1 * 2100 * 1000)); Testcase were wrong, bcz it was marked as waiting, but it has WF and wf has endtime. Since WF has ended, job should be in terminal state. > On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 192 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line192> > > > > Why remove this? There were two consecutive addStatusEvent call, since we are confirming with DB. It doesn't matter. I added it back. > On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java, line > > 107 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350704#file1350704line107> > > > > Why set expected end and change to end_miss? We need a test for > > start_miss It's old job, job end time < current time. Added test for end_miss. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46390/#review129630 ----------------------------------------------------------- On April 19, 2016, 8:54 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46390/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 8:54 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2509 > https://issues.apache.org/jira/browse/OOZIE-2509 > > > Repository: oozie-git > > > Description > ------- > > SLA job status can stuck in running state > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 42313fd3ab804c527afc115402295916b29f63d2 > core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > 795db37316d6ced825618f6976133691c02bd940 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 432efef6989951b0d66405dd3762cbfe2c965556 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 7a710c28cf035e528e7d024f254205d6c52d3309 > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > ebb12f77552f26aba962dddc63e3158d007b07a4 > core/src/test/java/org/apache/oozie/sla/TestSLAService.java > c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf > > Diff: https://reviews.apache.org/r/46390/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >