> On April 19, 2016, 9:59 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/sla/TestSLAService.java, line 231 > > <https://reviews.apache.org/r/46390/diff/1/?file=1350705#file1350705line231> > > > > Why change WAITING to FAILED? Need a test case for waiting. > > Purshotam Shah wrote: > CoordinatorActionBean action1 = > addRecordToCoordActionTable("coord-action-C@1", 1, > CoordinatorAction.Status.FAILED, "coord-action-get.xml", > 0); > WorkflowJobBean extWf = new WorkflowJobBean(); > extWf.setId(action1.getExternalId()); > extWf.setEndTime(new Date(System.currentTimeMillis() - 1 * 1800 * > 1000)); > extWf.setStartTime(new Date(System.currentTimeMillis() - 1 * 2100 > * 1000)); > > > Testcase were wrong, bcz it was marked as waiting, but it has WF and wf > has endtime. Since WF has ended, job should be in terminal state. > > Rohini Palaniswamy wrote: > Can we remove the workflow database entry instead? There is already a > FAILED case, but no other testcase for waiting state. FAILED will take the > isTerminalWithFailure codepath.
added testcase for waiting. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46390/#review129630 ----------------------------------------------------------- On April 20, 2016, 5:13 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46390/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 5:13 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2509 > https://issues.apache.org/jira/browse/OOZIE-2509 > > > Repository: oozie-git > > > Description > ------- > > SLA job status can stuck in running state > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > b1be7c9393ae8c5f788644fae6b6ece78b2ae4b0 > > core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 128feb21993156fd33798fb9178ef926c0e832cc > > core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLACoordActionJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/sla/SLAJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > core/src/main/java/org/apache/oozie/command/sla/SLAJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowActionJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobEventXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/command/sla/SLAWorkflowJobHistoryXCommand.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > 79ec28cac6a6b0d874239904fca61cac756eab35 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 078fd404993d96b7fd62215a617b4cac6cfbf455 > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > ce108d56f4cf6e124cd99be2e28cc1cea764077e > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 42313fd3ab804c527afc115402295916b29f63d2 > core/src/main/java/org/apache/oozie/sla/SLAXCommandFactory.java > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java > 52560e67fdec2e8671d17a2e7cf21633156505e6 > core/src/test/java/org/apache/oozie/service/TestHASLAService.java > 795db37316d6ced825618f6976133691c02bd940 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 432efef6989951b0d66405dd3762cbfe2c965556 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 7a710c28cf035e528e7d024f254205d6c52d3309 > core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java > ebb12f77552f26aba962dddc63e3158d007b07a4 > core/src/test/java/org/apache/oozie/sla/TestSLAService.java > c3bc110d825f4e3b9a1afe1becd4b045e8c6dacf > > Diff: https://reviews.apache.org/r/46390/diff/ > > > Testing > ------- > > Removed unused jpa class. Somehow it's not part of patch. Will remove them > while committing. > > $ git status | grep delete > deleted: > src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForSLAJPAExecutor.java > deleted: > src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetForSLAJPAExecutor.java > deleted: > src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetForSLAJPAExecutor.java > $ > > > Thanks, > > Purshotam Shah > >
