> On Nov. 25, 2016, 8:41 a.m., Peter Bacsko wrote: > > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java, line 58 > > <https://reviews.apache.org/r/54060/diff/1/?file=1570096#file1570096line58> > > > > Shouldn't we do some sort of validation here? Eg. what is there is a > > typo in the scheme, like "hcta". Or it's longer than 4 chars.
I do not think that will be good idea. I guess we can expect users to provide the scheme. > On Nov. 25, 2016, 8:41 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java, line 315 > > <https://reviews.apache.org/r/54060/diff/1/?file=1570091#file1570091line315> > > > > I can see it's not your change, but this is pretty ugly here. The > > production code performs a test whether it's running from a unit test... we > > really shouldn't do anything like that. Could you correct this somehow? I will check that. Thanks. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54060/#review156894 ----------------------------------------------------------- On Nov. 24, 2016, 11:24 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54060/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2016, 11:24 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2701 > https://issues.apache.org/jira/browse/OOZIE-2701 > > > Repository: oozie-git > > > Description > ------- > > Oozie to support Multiple HCatalog URIs > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 67b37ec > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > bbe9ea7 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 7062e69 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 25f250c > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java e1cf133 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java 8ec3fae > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1b1a8fa > > Diff: https://reviews.apache.org/r/54060/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
