> On Nov. 25, 2016, 8:39 a.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java, line 58 > > <https://reviews.apache.org/r/54060/diff/1/?file=1570090#file1570090line58> > > > > This change breaks backwards compatibility. Is it really needed? > > Abhishek Bafna wrote: > The way I understand it, This separator is not exposed to the users. Can > you help i understanding the backwards compatibility thing. Also, I used ',' > for separating the multiple urls and that is why changed this. If you have > any suggestion for url separation that will be great. Thanks.
You could use `,hcat://` as `DIR_SEPARATOR`. In that case: * we would use a separator that's backward compatible and compatible w/ other Oozie separators * we could be sure the `,` characters possibly used inside one HCAT connection strings are considered correctly Please also add a unit test that covers exactly that scheme: two HCAT connection strings, the one containing a `,` inside, and the other not. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54060/#review156897 ----------------------------------------------------------- On Nov. 24, 2016, 11:24 a.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54060/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2016, 11:24 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2701 > https://issues.apache.org/jira/browse/OOZIE-2701 > > > Repository: oozie-git > > > Description > ------- > > Oozie to support Multiple HCatalog URIs > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java 67b37ec > > core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > bbe9ea7 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 7062e69 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > 25f250c > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java e1cf133 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java 8ec3fae > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1b1a8fa > > Diff: https://reviews.apache.org/r/54060/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
