[ 
https://issues.apache.org/jira/browse/OOZIE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802228#comment-15802228
 ] 

Attila Sasvari commented on OOZIE-2756:
---------------------------------------

[~gezapeti] Many thanks for the review!

In a unit test I do not think it is acceptable to load external files like 
{{oozie-default.xml}} .  {{TestSSLServerConnectorFactory}} is to verify that 
SSLServerConnectorFactory can parse, read and apply given properties (empty 
properties are ignored). At the same time I agree that mentioning default in 
the test case name could cause confusion. 
 
I am going to fix test case names and {{oozie-default.xml}} in the next patch.
 

> Extend HTTPS configuration settings for embedded Jetty
> ------------------------------------------------------
>
>                 Key: OOZIE-2756
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2756
>             Project: Oozie
>          Issue Type: Improvement
>            Reporter: Attila Sasvari
>            Assignee: Attila Sasvari
>         Attachments: OOZIE-2756-01.patch, OOZIE-2756-02.patch
>
>
> Regarding HTTPS settings, currently Oozie only support  
> {{oozie.https.include.protocols}} and {{oozie.https.exclude.cipher.suites}} 
> (introduced by OOZIE-2666).
> However, Jetty SslContextFactory supports the following configurations:
> * excludeProtocols
> * includeProtocols
> * excludeCipherSuites
> * includeCipherSuites
> To have more control over employed protocols and cipher suites, we should 
> extend current implementation to allow users to configure 
> {{excludeProtocols}} and {{includeCipherSuites}}. Sensible defaults are also 
> needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to