[ 
https://issues.apache.org/jira/browse/OOZIE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811204#comment-15811204
 ] 

Attila Sasvari commented on OOZIE-2756:
---------------------------------------

[~abhishekbafna] I defined those constants in {{TestSSLServerConnectorFactory}} 
on purpose. The reason behind it is that if someone changes a configuration 
property's name (for example changes {{oozie.https.keystore.pass}} to 
{{oozie.https.keystore.password}}) and do not adjust constant in the test, this 
would catch it. Otherwise, if we reference constants in the actual code (i.e. 
the one in {{SSLServerConnectorFactory}}), it might go unnoticed. I am also 
against code duplication, but in this case, I think, it is reasonable. 

> Extend HTTPS configuration settings for embedded Jetty
> ------------------------------------------------------
>
>                 Key: OOZIE-2756
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2756
>             Project: Oozie
>          Issue Type: Improvement
>            Reporter: Attila Sasvari
>            Assignee: Attila Sasvari
>         Attachments: OOZIE-2756-01.patch, OOZIE-2756-02.patch, 
> OOZIE-2756-03.patch, OOZIE-2756-04.patch
>
>
> Regarding HTTPS settings, currently Oozie only support  
> {{oozie.https.include.protocols}} and {{oozie.https.exclude.cipher.suites}} 
> (introduced by OOZIE-2666).
> However, Jetty SslContextFactory supports the following configurations:
> * excludeProtocols
> * includeProtocols
> * excludeCipherSuites
> * includeCipherSuites
> To have more control over employed protocols and cipher suites, we should 
> extend current implementation to allow users to configure 
> {{excludeProtocols}} and {{includeCipherSuites}}. Sensible defaults are also 
> needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to