----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review185497 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 46 (patched) <https://reviews.apache.org/r/62352/#comment261787> ? core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 56 (patched) <https://reviews.apache.org/r/62352/#comment261788> ? core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 57-58 (patched) <https://reviews.apache.org/r/62352/#comment261789> Add descriptions like the above constructor core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 75 (patched) <https://reviews.apache.org/r/62352/#comment261790> description core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 81 (patched) <https://reviews.apache.org/r/62352/#comment261791> Should this go in the ``newXMLReader()`` method? core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 83-84 (patched) <https://reviews.apache.org/r/62352/#comment261792> Remove core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java Lines 86 (patched) <https://reviews.apache.org/r/62352/#comment261793> Do we need to close this? pom.xml Lines 1510 (patched) <https://reviews.apache.org/r/62352/#comment261786> Looks like the newest version is 0.2.2. Any reason why we're using 0.1.6? http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22guru.nidi%22%20AND%20a%3A%22graphviz-java%22 (That said, 0.1.6 is only from May 2017, so it's not actually that old) - Robert Kanter On Sept. 15, 2017, 12:45 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62352/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2017, 12:45 p.m.) > > > Review request for oozie and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2406 Completely rewrite GraphGenerator code > > > Diffs > ----- > > core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 > core/src/main/java/org/apache/oozie/util/GraphGenerator.java > 6ded2c6dc15c9e8453ff800407ff0324be185f41 > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java > PRE-CREATION > core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 002e925b57cd830ea6d83a87cea4383165116b80 > core/src/test/resources/graph-with-many-nodes.png PRE-CREATION > core/src/test/resources/graphWF_100_actions.xml PRE-CREATION > pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b > sharelib/oozie/pom.xml c74c06df5313b340e27747dfdf9126b3479674af > > > Diff: https://reviews.apache.org/r/62352/diff/1/ > > > Testing > ------- > > `TestGraphGenerator` > > > Thanks, > > András Piros > >
