> On Sept. 18, 2017, 11:39 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/62352/diff/2/?file=1828289#file1828289line47> > > > > Should we make this configurable via oozie-site?
Removed totally. > On Sept. 18, 2017, 11:39 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java > > Lines 150 (patched) > > <https://reviews.apache.org/r/62352/diff/2/?file=1828295#file1828295line150> > > > > Isn't this going to cause an NPE when using Jung because JungRenderer > > returns ``null`` for ``renderDot()``? We should probably check if ``dot == > > null`` and do something nicer. As `JungRenderer` is removed, this is not an issue anymore. Anyway, introducing nullcheck. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62352/#review185629 ----------------------------------------------------------- On Sept. 17, 2017, 5:28 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62352/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2017, 5:28 p.m.) > > > Review request for oozie and Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2406 Completely rewrite GraphGenerator code > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 74843dc9a3cbb8cef38e97f81e34731f191d9aab > core/pom.xml b0809546d048c2acbcbea8af5f8947eb0eaece9e > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 10812c675ebc0cc4aefca9f4a85ef2fc26d143e1 > core/src/main/java/org/apache/oozie/util/GraphGenerator.java > 6ded2c6dc15c9e8453ff800407ff0324be185f41 > core/src/main/java/org/apache/oozie/util/graph/GraphGenerator.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/GraphvizRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/JungRenderer.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/OutputFormat.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowActionNode.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/graph/WorkflowGraphHandler.java > PRE-CREATION > core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java > ee9ab556c9b6930c406ca5dcd54065cbbebb86c9 > core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 002e925b57cd830ea6d83a87cea4383165116b80 > core/src/test/java/org/apache/oozie/util/graph/TestGraphGenerator.java > PRE-CREATION > core/src/test/resources/graphWF.xml > 6a7b0427a9951835a7533a04b66258ded369d5bf > core/src/test/resources/graphWF_26_actions.xml > a091be0f3559ede195ccc3339adee4478a8da8c0 > core/src/test/resources/graphWF_50_actions.xml PRE-CREATION > docs/src/site/twiki/WebServicesAPI.twiki > ef3e60242512decd48beb3d8c9ac747b7d128eda > pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b > > > Diff: https://reviews.apache.org/r/62352/diff/2/ > > > Testing > ------- > > `TestGraphGenerator`, `TestV1JobServlet` > > > Thanks, > > András Piros > >