> On Nov. 15, 2017, 3:29 p.m., András Piros wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > > Lines 381 (patched) > > <https://reviews.apache.org/r/63837/diff/3/?file=1893409#file1893409line385> > > > > Typo: `Could not...`
I really have to learn to type... > On Nov. 15, 2017, 3:29 p.m., András Piros wrote: > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > > Line 107 (original), 104 (patched) > > <https://reviews.apache.org/r/63837/diff/3/?file=1893410#file1893410line108> > > > > When modified, please set it back to a runnable test method: `public > > void testXXXX()` This is a helper function called from other tests. It shouldn't be called on it's own. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/#review191066 ----------------------------------------------------------- On Nov. 16, 2017, 9:55 a.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63837/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 9:55 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3112 > https://issues.apache.org/jira/browse/OOZIE-3112 > > > Repository: oozie-git > > > Description > ------- > > SparkConfigurationService injects the config values as --conf to SparkSubmit. > This will overwrite propties provided in the --properies-file option which is > not the expected behavior. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 80d64ec80 > docs/src/site/twiki/DG_SparkActionExtension.twiki 45b60b86b > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 052950fa3 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > d97f1f06b > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 574bf2403 > > > Diff: https://reviews.apache.org/r/63837/diff/4/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
