----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/#review191175 -----------------------------------------------------------
docs/src/site/twiki/DG_SparkActionExtension.twiki Lines 119 (patched) <https://reviews.apache.org/r/63837/#comment268806> Minor review comments: - To me, the following might sound better: There are several ways to pass properties to Spark. They are processed in the following order: 1, ... 2, ... 3, ... 4, ... (The latter takes precedence over the former.) Note: The server propagated properties, the =spark-defaults.conf= and the user-defined properties file are merged together into a single properties file as Spark handles only one file in its =--properties-file= option. typos: - from ``server-propagated`` to ``server propagated`` - from ``in it's`` to ``in its`` - Attila Sasvari On Nov. 16, 2017, 10:04 a.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63837/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2017, 10:04 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3112 > https://issues.apache.org/jira/browse/OOZIE-3112 > > > Repository: oozie-git > > > Description > ------- > > SparkConfigurationService injects the config values as --conf to SparkSubmit. > This will overwrite propties provided in the --properies-file option which is > not the expected behavior. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 80d64ec80 > docs/src/site/twiki/DG_SparkActionExtension.twiki 45b60b86b > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 052950fa3 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > d97f1f06b > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 574bf2403 > > > Diff: https://reviews.apache.org/r/63837/diff/5/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
