----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66181/ -----------------------------------------------------------
Review request for oozie, András Piros and Attila Sasvari. Bugs: OOZIE-3056 https://issues.apache.org/jira/browse/OOZIE-3056 Repository: oozie-git Description ------- Refactored out Sharelib name resolution from JavaAE as an additional step to pick that giant class to pieces. Added logic to process the <sharelib> properties added in <launcher> sections. Diffs ----- core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 122dfd02e17456b9aab924504faee790813fb6a1 core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java PRE-CREATION core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java b55a3cd7f8064cd898edc686891c9f6ebb118c42 core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibResolver.java PRE-CREATION Diff: https://reviews.apache.org/r/66181/diff/1/ Testing ------- Added Junit tests to validate that 1) the configs are propagating and overwriting each other correctly when an xml is formatted 2) the configs are resolved in the correct order for sharelib names Thanks, Peter Cseh