> On March 21, 2018, 1:28 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1862-1875 (original), 1846-1848 (patched) > > <https://reviews.apache.org/r/66181/diff/1/?file=1983709#file1983709line1863> > > > > Remove `catch` block as it's already handled by > > `SharelibResolver#resolve()`.
It turns out that I don't need the try-catch in the Resolver. > On March 21, 2018, 1:28 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java > > Lines 76-78 (patched) > > <https://reviews.apache.org/r/66181/diff/1/?file=1983710#file1983710line76> > > > > What about `[""]`, that is, a `String[]` consisting of only empty > > `String` instances? conf.getStrings() does not give back empty strings in the arrays. > On March 21, 2018, 1:28 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > > Lines 1251-1265 (patched) > > <https://reviews.apache.org/r/66181/diff/1/?file=1983711#file1983711line1251> > > > > What about a new test class that `extends MiniOozieTestCase` instead? > > `TestJavaActionExecutor` is lengthy enough already. Done. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66181/#review199656 ----------------------------------------------------------- On March 20, 2018, 9:04 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66181/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 9:04 p.m.) > > > Review request for oozie, András Piros and Attila Sasvari. > > > Bugs: OOZIE-3056 > https://issues.apache.org/jira/browse/OOZIE-3056 > > > Repository: oozie-git > > > Description > ------- > > Refactored out Sharelib name resolution from JavaAE as an additional step to > pick that giant class to pieces. > Added logic to process the <sharelib> properties added in <launcher> sections. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 122dfd02e17456b9aab924504faee790813fb6a1 > core/src/main/java/org/apache/oozie/action/hadoop/SharelibResolver.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > b55a3cd7f8064cd898edc686891c9f6ebb118c42 > core/src/test/java/org/apache/oozie/action/hadoop/TestSharelibResolver.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66181/diff/1/ > > > Testing > ------- > > Added Junit tests to validate that > 1) the configs are propagating and overwriting each other correctly when an > xml is formatted > 2) the configs are resolved in the correct order for sharelib names > > > Thanks, > > Peter Cseh > >
