[
https://issues.apache.org/jira/browse/OOZIE-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407311#comment-16407311
]
Hadoop QA commented on OOZIE-3056:
----------------------------------
Testing JIRA OOZIE-3056
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:red}-1{color} the patch contains 2 line(s) longer than 132
characters
. {color:green}+1{color} the patch adds/modifies 2 testcase(s)
{color:red}-1 RAT{color}
. {color:red}-1{color} the patch seems to introduce 2 new RAT warning(s)
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 2098
. Tests failed: 2
. Tests errors: 1
. The patch failed the following testcases:
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerService)
. Tests failing with errors:
testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService)
. {color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone
. For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/454/
> Implement new mechanism to specify ShareLibs for workflow actions
> -----------------------------------------------------------------
>
> Key: OOZIE-3056
> URL: https://issues.apache.org/jira/browse/OOZIE-3056
> Project: Oozie
> Issue Type: New Feature
> Components: core
> Affects Versions: 5.0.0
> Reporter: Attila Sasvari
> Assignee: Peter Cseh
> Priority: Critical
> Fix For: 5.0.0
>
> Attachments: OOZIE-3056.001.patch
>
>
> OOZIE-2687 introduces the {{launcher}} element for workflows:
> {code}
> <launcher>
> <memory>1024</memory>
> <vcores>1</vcores>
> <java-opts>-Dsome.property=true -XX:+RandomJVMSwitch</java-opts>
> <env>key=value</env>
> <queue>root.oozie</queue>
> <sharelib>spark,hive</sharelib>
> </launcher>
> {code}
> The purpose of this ticket is to discuss and implement new mechanism for
> handling ShareLib.
> {{addActionShareLib}} in {{JavaActionExecutor}} should adjusted. Regarding
> "precedence order":
> if global and an action level {{launcher}} and {{configuration}} (e.g.
> {{oozie.action.sharelib.for.#ACTIONTYPE#}}) tries to override the sharelib
> the following should apply:
> {quote}
> config properties defined in an action's <configuration> have priority over
> an action's <job-xml>, which has priority over the global section's
> <configuration> and <job-xml>, which has priority over the action defaults in
> oozie-site, and so on.
> {quote}
> Here we have multiple choices how to handle sharelib:
> - Alternative 1: override sharelib in a way that is consistent with current
> way of handling Oozie configuration settings.
> - Alternative 2: make sharelib additive
> -- For example, if there is a global {{launcher}} with {{sharelib}} element
> in a workflow that includes multiple ShareLibs (e.g. A,B), and
> {{oozie.action.sharelib.for.#ACTIONTYPE#}} is also specified for an action's
> configuration (e.g. C,D), then we take the union of the specified entities
> (A,B,C,D would be included).
> -- It's inconsistent with everything else
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
