----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67112/#review203009 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Line 41 (original), 41 (patched) <https://reviews.apache.org/r/67112/#comment285056> Please don't use * sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 85 (patched) <https://reviews.apache.org/r/67112/#comment285058> This one is used only in tests if I see correctly. Please move it ther. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 375-378 (patched) <https://reviews.apache.org/r/67112/#comment285059> Please add documentation about the affected properties and some reasoning on why are we doing this. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 381-389 (patched) <https://reviews.apache.org/r/67112/#comment285057> This part feels similar to parts of https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java Is it possible to reuse code from there? It's possible I'm missing something that makes that not feasable. - Peter Cseh On May 14, 2018, 11:04 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67112/ > ----------------------------------------------------------- > > (Updated May 14, 2018, 11:04 a.m.) > > > Review request for oozie and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3228 [Spark action] Can't load properties from spark-defaults.conf > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 2f3cfbe4dfa2c2015686d2f2ca09ec4de544f423 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 6a9baa5c7997198ab69f039f6a8884e49b13cad3 > > > Diff: https://reviews.apache.org/r/67112/diff/1/ > > > Testing > ------- > > `mvn clean test -Dtest=TestSparkArgsExtractor` > > > Thanks, > > András Piros > >
