> On May 16, 2018, 9:57 a.m., Peter Cseh wrote: > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > > Lines 379-398 (patched) > > <https://reviews.apache.org/r/67112/diff/3/?file=2023950#file2023950line379> > > > > Can you also add this on the twiki level? Most users don't check the > > source code if something happens they don't expect.
Good idea! Added to `DG_SparkActionExtension.twiki`. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67112/#review203207 ----------------------------------------------------------- On May 16, 2018, 9:23 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67112/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 9:23 a.m.) > > > Review request for oozie and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3228 [Spark action] Can't load properties from spark-defaults.conf > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 5af39cda52b403d8989fdd5d4f2524395a55580a > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 6a9baa5c7997198ab69f039f6a8884e49b13cad3 > > > Diff: https://reviews.apache.org/r/67112/diff/3/ > > > Testing > ------- > > `mvn clean test -Dtest=TestSparkArgsExtractor` > > > Thanks, > > András Piros > >