----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69437/#review210853 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java Lines 150-151 (original), 150-151 (patched) <https://reviews.apache.org/r/69437/#comment295612> Please remove commented lines core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java Line 171 (original), 172 (patched) <https://reviews.apache.org/r/69437/#comment295614> Possible NPE, if retriesList==null. core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java Lines 214 (patched) <https://reviews.apache.org/r/69437/#comment295613> Wouldn't be better to return an empty(Collections.emptyList()) list instead of null in order to avoid NPEs or null checks? - Kinga Marton On Nov. 23, 2018, 12:50 p.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69437/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2018, 12:50 p.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3384 - [tests] > TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java > 5c06ae554 > > > Diff: https://reviews.apache.org/r/69437/diff/1/ > > > Testing > ------- > > Executed 50 times using grind: > > 50/50 tests complete > > > Thanks, > > Andras Salamon > >
