> On Nov. 26, 2018, 9:10 a.m., Kinga Marton wrote: > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java > > Lines 214 (patched) > > <https://reviews.apache.org/r/69437/diff/1/?file=2110235#file2110235line217> > > > > Wouldn't be better to return an empty(Collections.emptyList()) list > > instead of null in order to avoid NPEs or null checks?
Unfortunately command.call() can also return null, so I cannot eliminate the null checks. Reorganized the checks a bit to make it more logical. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69437/#review210853 ----------------------------------------------------------- On Nov. 26, 2018, 11:17 a.m., Andras Salamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69437/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 11:17 a.m.) > > > Review request for oozie, András Piros and Kinga Marton. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3384 - [tests] > TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrlForked() is flaky > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java > 5c06ae554 > > > Diff: https://reviews.apache.org/r/69437/diff/2/ > > > Testing > ------- > > Executed 50 times using grind: > > 50/50 tests complete > > > Thanks, > > Andras Salamon > >
