[ https://issues.apache.org/jira/browse/OOZIE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801997#comment-16801997 ]
Hadoop QA commented on OOZIE-3443: ---------------------------------- Testing JIRA OOZIE-3443 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [6] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [6] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important SpotBugs errors are: . At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection . At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] . At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] . This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] . At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:orange}0{color} There are [4] new bugs found in [server] that would be nice to have fixed. . You can find the SpotBugs diff here: server/findbugs-new.html . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 3169 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1061/ > Migrate from joda time to java.time > ----------------------------------- > > Key: OOZIE-3443 > URL: https://issues.apache.org/jira/browse/OOZIE-3443 > Project: Oozie > Issue Type: Improvement > Affects Versions: trunk > Reporter: Andras Salamon > Assignee: Mate Juhasz > Priority: Minor > Attachments: OOZIE-3443-V1.patch, OOZIE-3443-V2.patch, > OOZIE-3443-V3.patch > > > From Java SE 8 onwards, users are asked to migrate to from [joda > time|https://www.joda.org/joda-time/] to java.time (JSR-310). > It seems to me, that we only use it directly in one place: > [TestWorkflowActionRetryInfoXCommand.java|https://github.com/apache/oozie/blob/master/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionRetryInfoXCommand.java] > so it would be not too difficult to migrate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)