[ https://issues.apache.org/jira/browse/OOZIE-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804022#comment-16804022 ]
Hadoop QA commented on OOZIE-3455: ---------------------------------- Testing JIRA OOZIE-3455 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [6] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [6] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important SpotBugs errors are: . At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection . At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] . At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] . This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] . At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run : 3169 . Tests failed : 0 . Tests in error : 1 . Tests timed out : 0 {color:red}-1{color} [ERROR] There are [1] test errors in [core]. Listing only the first [5] ones testJMXInstrumentation:org.apache.oozie.util.TestMetricsInstrumentation Check console output for the full list of errors/failures {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1066/ > Inconsistent CoordMaterializeTransitionXCommand logging > -------------------------------------------------------- > > Key: OOZIE-3455 > URL: https://issues.apache.org/jira/browse/OOZIE-3455 > Project: Oozie > Issue Type: Bug > Reporter: Andras Salamon > Assignee: Andras Salamon > Priority: Major > Attachments: OOZIE-3455-01.patch > > > Logging of {{CoordMaterializeTransitionXCommand}} lock acquiring is > incomplete. The following four lines is printed by > {{TestCoordMaterializeTransitionXCommand.testMaterializationLookupRelativeDays3()}}. > The first two lines does not contain the {{USER[test] GROUP[testg] TOKEN[] > APP[COORD-TEST] JOB[0000000-190327125652192-oozie-andr-C] ACTION[-]}} > {noformat} > 12:56:52,866 DEBUG CoordMaterializeTransitionXCommand:526 - Acquired lock for > [0000000-190327125652192-oozie-andr-C] in [coord_mater] > 12:56:52,899 DEBUG CoordMaterializeTransitionXCommand:526 - Materializing > coord job id=0000000-190327125652192-oozie-andr-C, start=2019-03-27T11:56Z, > end=2019-03-27T12:56Z, window=3600 > 12:56:52,900 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327125652192-oozie-andr-C] ACTION[-] Execute command > [coord_mater] key [0000000-190327125652192-oozie-andr-C] > 12:56:52,916 INFO CoordMaterializeTransitionXCommand:520 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327125652192-oozie-andr-C] ACTION[-] materialize actions for > tz=Pacific Standard Time, > {noformat} > Sometimes the information is not missing, but contains info from a previous > run, which is very confusing: > {noformat} > 6:39:57,236 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327163956391-oozie-andr-C] ACTION[-] Acquired lock for > [0000000-190327163956963-oozie-andr-C] in [coord_mater] > 16:39:57,252 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327163956391-oozie-andr-C] ACTION[-] Materializing coord job > id=0000000-190327163956963-oozie-andr-C, start=2013-07-18T00:00Z, > end=2013-07-18T01:00Z, window=3600 > 16:39:57,252 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327163956963-oozie-andr-C] ACTION[-] Execute command > [coord_mater] key [0000000-190327163956963-oozie-andr-C] > 16:39:57,255 INFO CoordMaterializeTransitionXCommand:520 - USER[test] > GROUP[testg] TOKEN[] APP[COORD-TEST] > JOB[0000000-190327163956963-oozie-andr-C] ACTION[-] materialize actions for > tz=Pacific Standard Time, > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)