[
https://issues.apache.org/jira/browse/OOZIE-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815468#comment-16815468
]
Andras Salamon commented on OOZIE-3455:
---------------------------------------
I've started to implement the log cleanup at the end of the {{XCommand}}, the
results look good, the {{Acquired lock for}} line no longer contains info about
the previous job (like user, group, and token), and at the end of the unit test
log line changes from
{noformat}
15:56:43,429 INFO Services:520 - USER[test] GROUP[testg] TOKEN[]
APP[COORD-TEST] JOB[0000000-190411155642913-oozie-andr-C] ACTION[]
Shutdown{noformat}
to
{noformat}
16:32:11,464 INFO Services:520 - USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-]
ACTION[-] Shutdown
{noformat}
which is more logical because the service shutdown is not connected to a job.
I've added the log cleanup to the end of the {{XCommand}} class so it affects
all the commands not only CoordMaterializeTransitionXCommand. I don't think
that this jira is the correct place to address this issue. I'd rather modify
only {{CoordMaterializeTransitionXCommand}} problems in this jira, and a
separate jira should modify {{XCommand}}. What do you think [~kmarton]?
> Inconsistent CoordMaterializeTransitionXCommand logging
> --------------------------------------------------------
>
> Key: OOZIE-3455
> URL: https://issues.apache.org/jira/browse/OOZIE-3455
> Project: Oozie
> Issue Type: Bug
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Major
> Attachments: OOZIE-3455-01.patch
>
>
> Logging of {{CoordMaterializeTransitionXCommand}} lock acquiring is
> incomplete. The following four lines is printed by
> {{TestCoordMaterializeTransitionXCommand.testMaterializationLookupRelativeDays3()}}.
> The first two lines does not contain the {{USER[test] GROUP[testg] TOKEN[]
> APP[COORD-TEST] JOB[0000000-190327125652192-oozie-andr-C] ACTION[-]}}
> {noformat}
> 12:56:52,866 DEBUG CoordMaterializeTransitionXCommand:526 - Acquired lock for
> [0000000-190327125652192-oozie-andr-C] in [coord_mater]
> 12:56:52,899 DEBUG CoordMaterializeTransitionXCommand:526 - Materializing
> coord job id=0000000-190327125652192-oozie-andr-C, start=2019-03-27T11:56Z,
> end=2019-03-27T12:56Z, window=3600
> 12:56:52,900 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327125652192-oozie-andr-C] ACTION[-] Execute command
> [coord_mater] key [0000000-190327125652192-oozie-andr-C]
> 12:56:52,916 INFO CoordMaterializeTransitionXCommand:520 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327125652192-oozie-andr-C] ACTION[-] materialize actions for
> tz=Pacific Standard Time,
> {noformat}
> Sometimes the information is not missing, but contains info from a previous
> run, which is very confusing:
> {noformat}
> 6:39:57,236 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327163956391-oozie-andr-C] ACTION[-] Acquired lock for
> [0000000-190327163956963-oozie-andr-C] in [coord_mater]
> 16:39:57,252 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327163956391-oozie-andr-C] ACTION[-] Materializing coord job
> id=0000000-190327163956963-oozie-andr-C, start=2013-07-18T00:00Z,
> end=2013-07-18T01:00Z, window=3600
> 16:39:57,252 DEBUG CoordMaterializeTransitionXCommand:526 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327163956963-oozie-andr-C] ACTION[-] Execute command
> [coord_mater] key [0000000-190327163956963-oozie-andr-C]
> 16:39:57,255 INFO CoordMaterializeTransitionXCommand:520 - USER[test]
> GROUP[testg] TOKEN[] APP[COORD-TEST]
> JOB[0000000-190327163956963-oozie-andr-C] ACTION[-] materialize actions for
> tz=Pacific Standard Time,
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
