[ https://issues.apache.org/jira/browse/OOZIE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817280#comment-16817280 ]
Hadoop QA commented on OOZIE-3464: ---------------------------------- Testing JIRA OOZIE-3464 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any star imports . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 107 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} Javadoc generation succeeded with the patch . {color:green}+1{color} the patch does not seem to introduce new Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [32] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:red}-1{color} There are [7] new bugs found below threshold in [core] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): core/findbugs-new.html . The top [5] most important SpotBugs errors are: . At BulkJPAExecutor.java:[line 207]: This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection . At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176] . At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200] . This use of javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query; can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207] . At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128] . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:red}-1{color} There are [1] new bugs found below threshold in [sharelib/oozie] that must be fixed. . You can find the SpotBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The most important SpotBugs errors are: . At LauncherMain.java:[line 148]: java/io/FileInputStream.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input . At LauncherMain.java:[line 181] . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/git]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [24] new bugs found below threshold in [tools] that must be fixed, listing only the first [5] ones. . You can find the SpotBugs diff here (look for the red and orange ones): tools/findbugs-new.html . The top [5] most important SpotBugs errors are: . At OozieDBCLI.java:[line 570]: java/io/FileOutputStream.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . At OozieDBCLI.java:[line 132]: At OozieDBCLI.java:[line 128] . At OozieDBCLI.java:[line 238]: At OozieDBCLI.java:[line 139] . At OozieDBCLI.java:[line 727]: At OozieDBCLI.java:[line 263] . At OozieDBCLI.java:[line 600]: java/io/FileOutputStream.<init>(Ljava/lang/String;Z)V writes to a file whose location might be specified by user input . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [fluent-job/fluent-job-api]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run : 3169 . Tests failed : 0 . Tests in error : 3 . Tests timed out : 0 {color:red}-1{color} [ERROR] There are [3] test errors in [core]. Listing only the first [5] ones testValidateWorkFlowCommand:org.apache.oozie.client.TestOozieCLI Check console output for the full list of errors/failures . {color:orange}Tests failed at first run:{color} TestWorkflowRetries>TestWorkflow#testWorkflowWithStartAndEndCompletesSuccessfully . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/1087/ > Use UTF8 charset instead of default one > --------------------------------------- > > Key: OOZIE-3464 > URL: https://issues.apache.org/jira/browse/OOZIE-3464 > Project: Oozie > Issue Type: Bug > Reporter: Julia Kinga Marton > Assignee: duan xiong > Priority: Major > Attachments: OOZIE-3464-001.patch, OOZIE-3464-002.patch > > > There are some places in code, when we are reading/writing to files and we do > not define any character set, so the default one will be used. Since the > default implementation may change between the java versions our output will > be platform dependent. > For example if we have a shell action with a script that will echo something > using Chinese text, '????' are be printed in case of jdk1.8.0_141. -- This message was sent by Atlassian JIRA (v7.6.3#76005)