[
https://issues.apache.org/jira/browse/OOZIE-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836113#comment-16836113
]
Andras Salamon commented on OOZIE-3464:
---------------------------------------
Thanks for the next patch [~nobigo]
It seems to me you also removed the import which became unused after your
modification like {{import java.io.FileReader}} which is very good.
Occasionally you also removed other unused imports from the same files, which
is also OK.
Sometimes you also remove unused import from files, where you don't modify
anything UTF-8 related (like {{TestLauncherAMUtils}} or
{{SparkConfigurationService}}. I would rather not modify those files in this
patch, because it's not related to the UTF-8 change.
> Use UTF8 charset instead of default one
> ---------------------------------------
>
> Key: OOZIE-3464
> URL: https://issues.apache.org/jira/browse/OOZIE-3464
> Project: Oozie
> Issue Type: Bug
> Reporter: Julia Kinga Marton
> Assignee: duan xiong
> Priority: Major
> Attachments: OOZIE-3464-001.patch, OOZIE-3464-002.patch,
> OOZIE-3464-003.patch, OOZIE-3464-004.patch
>
>
> There are some places in code, when we are reading/writing to files and we do
> not define any character set, so the default one will be used. Since the
> default implementation may change between the java versions our output will
> be platform dependent.
> For example if we have a shell action with a script that will echo something
> using Chinese text, '????' are be printed in case of jdk1.8.0_141.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
