I've looked at it before, actually. I think it looks good, but there's 24 files being changed, and some considerable changes. I think we should give Pam a few days to take a look and chime in before merging unless you're more confident about the changes than I am. I'm just not as familiar with this code base as she is, particularly in the periphery like " openaz-pep/src/test/resources/policies/TestPolicy001.xml". Alternately, you could do the merge to a branch for now.
On Wed, May 18, 2016 at 9:40 PM, Ajith Nair <[email protected]> wrote: > Folks, > > There is one outstanding pull request (from Dirk Koehler) that I have had > a chance to review. The changes look good and I would like to merge that > in. However, I guess I am lost as to how to do this. Can I do this from > github ? If so, how can I ensure that my write access(as a committer) is > reflected there ? > > Also, would Pam or David be interested in reviewing the changes ? Frankly, > I am not sure what’s the recommended approach around this. > > Thanks, > Ajith
