Thank you all. I’ve merged it into a new ‘wip’ branch for now and pushed it up.
I am probably most familiar with openaz-pep than other modules, since I was closely involved in putting in together. The pep API was originally part of legacy OpenLiberty OpenAz. The intent was to provide a simple Java centric API that developers can easily adopt without having to know the intricacies of XACML. So, when we speak about a “Hello World” for openaz, I think this fits right in :) Before being ported over to apache, it went through a major redesign but retained some of the core ideas. There’s lots of room for improvement and hopefully that will happen with more eyes on it. Regarding the pull request - the changes that matter are mostly around Subject, Action and Resource classes and their respective mappers. It looks like a bit of clean up was done, some test policy files renamed and their references updated. This is contributing to number of files affected. Anyway, I am following up with Dirk about one minor item regarding configurable subject, action and resource attribute ids. It’s highly likely that the existing implementation of this feature may have caused some confusion. Thanks, Ajith > On May 19, 2016, at 1:36 PM, David Ash <[email protected] > <mailto:[email protected]>> wrote: > > I've looked at it before, actually. I think it looks good, but there's 24 > files being changed, and some considerable changes. I think we should give > Pam a few days to take a look and chime in before merging unless you're > more confident about the changes than I am. I'm just not as familiar with > this code base as she is, particularly in the periphery like " > openaz-pep/src/test/resources/policies/TestPolicy001.xml". > Alternately, you could do the merge to a branch for now. > > On Wed, May 18, 2016 at 9:40 PM, Ajith Nair <[email protected] > <mailto:[email protected]>> wrote: > >> Folks, >> >> There is one outstanding pull request (from Dirk Koehler) that I have had >> a chance to review. The changes look good and I would like to merge that >> in. However, I guess I am lost as to how to do this. Can I do this from >> github ? If so, how can I ensure that my write access(as a committer) is >> reflected there ? >> >> Also, would Pam or David be interested in reviewing the changes ? Frankly, >> I am not sure what’s the recommended approach around this. >> >> Thanks, >> Ajith
