Hi Viola, On Jul 5, 2010, at 6:00 PM, viola.lu wrote:
> I already provided a patch for > https://issues.apache.org/jira/browse/OPENEJB-1303, seems feed won't catch > thi update, can you help review it? Looks like a great start! Went ahead and applied it. Thank you! > And there is a problem here, may bug or not: > Set replaced aged as true via: > statelessContainerInfo.properties.setProperty("ReplaceAged", "true"); , but > its attribute value is still false by getting mbeanserver attribute > value://ReplaceAged false, not sure whether it's openejb issue or its > attribute name is right? Sounds like a bug. As you note in the JIRA PollInterval also seems wrong. We definitely should have a test that changes all the pool configuration settings on the container and verifies that those settings are correct in the stats. There seems to also be a bug with the "Latest" times as well. We should pick one of the "Latest" stats and test it a bit. We should at least reparse the date and at least check the day, month and year are correct. Currently it says 1970 or something strange as the year which definitely isn't right. I split the pool related stats tests into a different test class and moved the javadoc at the top down onto test methods which still need to be implemented. I fixed PoolVersion so that it reports as an int rather than AtomicInteger -- that was also a bug. Thanks for all the work on this! It's clear we have some bugs to flush out before calling this code finished. The help is greatly appreciated! -David
