On Jul 8, 2010, at 3:18 AM, viola.lu wrote: > For accessTimeouts test, there will be an accesstimeout exception if > invocation against a full pool: > javax.ejb.ConcurrentAccessTimeoutException: No instances available in > Stateless Session Bean pool. Waited 1 MILLISECONDS. > For idletimouts test, i tried serveral way to check it, but it always keep > 0L, not sure why,from the comments: > Fill a pool to the max, let the non-min instances timeout, check the > IdleTimeouts, but after fill a max pull, non-min instances timeout > For aging, replaceAged setting still keep false. > > i attached the patch on jira > https://issues.apache.org/jira/browse/OPENEJB-1303 > pls help review it,
Thanks, Viola! I had some related changes already from fixing stats bugs, so I merged that patch in with my last commit with some modifications. I really like the actualDate.after(expected) technique in the sweeps test. That was super clever. It's so simple and effective I just went ahead and removed the year checking part since the "after" part is doing that and more. Going to have to remember that if I ever need to do some date testing. > thanks your help of improve my code in previous thread, > which make me learn more how to keep code simple and easy to read. No problem! It's been fun working on the tests with you. I'm really proud of our results. They look great and I never would have had time to do all alone. We're good on the stats and bugs now, but there's still a little work left on the Geronimo side. I added and renamed a few config properties, so we'll need to update the related Geronimo gbeans/plans to reflect. If you have time to help with that, it'd be wonderful. Thanks for all the great work, Viola! -David
