[
https://issues.apache.org/jira/browse/OPENJPA-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557448#action_12557448
]
Patrick Linskey commented on OPENJPA-477:
-----------------------------------------
Some more comments:
- A number of the changes make private fields more-visible. At least some of
these fields have accessors already; is there some reason why the accessors are
not sufficient? More importantly, when making private fields more visible, it's
important to do a careful analysis of what the impact of external mutation to
those fields would be.
- Is there any reason why you've changed some strings in DB2Dictionary to be
static final?
> making StoreManager more flexible and extensible.
> -------------------------------------------------
>
> Key: OPENJPA-477
> URL: https://issues.apache.org/jira/browse/OPENJPA-477
> Project: OpenJPA
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.0.2
> Reporter: Daniel Lee
> Fix For: 1.0.2, 1.1.0
>
> Attachments: OPENJPA-477.patch
>
>
> The OpenJPA StoreManager needs some modifications to make it more flexible
> and extensible. For example, some private methods and attributes need to
> made either public or protected. The attached patch identifies the areas
> that have been identified thus far. Please let me know if there are any
> concerns. Many thanks in advance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
