[
https://issues.apache.org/jira/browse/OPENJPA-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564448#action_12564448
]
Catalina Wei commented on OPENJPA-477:
--------------------------------------
Hi, Patrick,
1. answer to your question on the changes we made to BrokerImpl:
It's not that BrokerImpl needs an extension to detect whether these instances
are members of the working set. Rather, it's the BrokerImpl extension that
needs the ability to override this detection. This is a fine distinction. Our
BrokerImpl extension is only used while performing some pre-generation of sql
statements. It is not used during the actual openjpa runtime. We wanted to
use the same general mechanism for pre-generating sql as we do during runtime.
To accomplish this, we needed to extend BrokerImpl and provide some unique
processing for the object ids. We were trying to isolate the amount of code
that had to be overridden to accomplish this task. By introducing these two
new protected methods (checkForDuplicateId and assignObjectId), we could limit
the amount of code that needed to be overridden. We are open to other
suggestions.
2. thank you for removing 1.0.2 from the target release list.
Catalina
> making StoreManager more flexible and extensible.
> -------------------------------------------------
>
> Key: OPENJPA-477
> URL: https://issues.apache.org/jira/browse/OPENJPA-477
> Project: OpenJPA
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.0.2
> Reporter: Daniel Lee
> Fix For: 1.1.0
>
> Attachments: OPENJPA-477-trunk612523.patch, OPENJPA-477.613332.patch
>
>
> The OpenJPA StoreManager needs some modifications to make it more flexible
> and extensible. For example, some private methods and attributes need to
> made either public or protected. The attached patch identifies the areas
> that have been identified thus far. Please let me know if there are any
> concerns. Many thanks in advance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
