[
https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666131#comment-16666131
]
ASF GitHub Bot commented on OPENJPA-2754:
-----------------------------------------
struberg commented on a change in pull request #24: [OPENJPA-2754] maxActive ->
maxTotal
URL: https://github.com/apache/openjpa/pull/24#discussion_r228716889
##########
File path:
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/DBCPDriverDataSource.java
##########
@@ -194,8 +194,8 @@ private Properties updateDBCPProperties(Properties props) {
if (hasKey(dbcpProps, "minIdle") == null) {
dbcpProps.setProperty("minIdle", "0");
}
- if (hasKey(dbcpProps, "maxActive") == null) {
Review comment:
Hmmmm. Probably true. Those properties get applied via reflection anyway. So
every method which exists on a ConnectionFactory will get invoked afair. But we
should cross check this.
Probably we might even remove all that stuff? Because most of the pools have
sensible defaults anyway, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update to latest dbcp and verify moving from maxActive to maxTotal
> ------------------------------------------------------------------
>
> Key: OPENJPA-2754
> URL: https://issues.apache.org/jira/browse/OPENJPA-2754
> Project: OpenJPA
> Issue Type: Task
> Components: jdbc
> Affects Versions: 3.0.0
> Reporter: Mark Struberg
> Priority: Major
> Fix For: 3.0.1
>
>
> commons-dbcp 2 moved from maxActive to maxTotal
> https://commons.apache.org/proper/commons-dbcp/
> https://commons.apache.org/proper/commons-dbcp/configuration.html
> But all across our build we still use MaxActive.
> Do we like to keep this? Do we (via reflection) don't care and users need to
> care for themselves if they switch?
> Do we do it right in our unit tests right now?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
