[
https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684754#comment-16684754
]
ASF GitHub Bot commented on OPENJPA-2754:
-----------------------------------------
rmannibucau commented on issue #24: [OPENJPA-2754] maxActive -> maxTotal
URL: https://github.com/apache/openjpa/pull/24#issuecomment-438146757
@solomax hmm, overall looks ok except jdbc.DriverDataSource which lost dbcp
option (so can't be a 3.0.1). Shouldnt we put the BasicDataSource class of dbcp
here even if we don't deliver it? Idea of dropping the wrappers was to support
it by reflection so theorically we can keep it, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update to latest dbcp and verify moving from maxActive to maxTotal
> ------------------------------------------------------------------
>
> Key: OPENJPA-2754
> URL: https://issues.apache.org/jira/browse/OPENJPA-2754
> Project: OpenJPA
> Issue Type: Task
> Components: jdbc
> Affects Versions: 3.0.0
> Reporter: Mark Struberg
> Priority: Major
> Fix For: 3.0.1
>
>
> commons-dbcp 2 moved from maxActive to maxTotal
> https://commons.apache.org/proper/commons-dbcp/
> https://commons.apache.org/proper/commons-dbcp/configuration.html
> But all across our build we still use MaxActive.
> Do we like to keep this? Do we (via reflection) don't care and users need to
> care for themselves if they switch?
> Do we do it right in our unit tests right now?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
