[ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732417#comment-16732417 ]
Mark Struberg commented on OPENJPA-2754: ---------------------------------------- Oh just saw the comment from [~romain.manni-bucau]. The old logic was actually using reflection already. In the sense that it used Class.forName and only enabled dbcp2 if present. Gonna revert those parts. The rest is cool! > update to latest dbcp and verify moving from maxActive to maxTotal > ------------------------------------------------------------------ > > Key: OPENJPA-2754 > URL: https://issues.apache.org/jira/browse/OPENJPA-2754 > Project: OpenJPA > Issue Type: Task > Components: jdbc > Affects Versions: 3.0.0 > Reporter: Mark Struberg > Assignee: Maxim Solodovnik > Priority: Major > Fix For: 3.0.1 > > > commons-dbcp 2 moved from maxActive to maxTotal > https://commons.apache.org/proper/commons-dbcp/ > https://commons.apache.org/proper/commons-dbcp/configuration.html > But all across our build we still use MaxActive. > Do we like to keep this? Do we (via reflection) don't care and users need to > care for themselves if they switch? > Do we do it right in our unit tests right now? -- This message was sent by Atlassian JIRA (v7.6.3#76005)