[
https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689077#comment-16689077
]
ASF GitHub Bot commented on OPENJPA-2754:
-----------------------------------------
solomax commented on issue #24: [OPENJPA-2754] maxActive -> maxTotal
URL: https://github.com/apache/openjpa/pull/24#issuecomment-439294545
@rmannibucau is it better this way? shall I also update
https://github.com/apache/openjpa/pull/24/commits/0282a7e49fc4269b5543c2e95028ceb64b5c2f6b#diff-0f248e1fb6e3433b23f588d9646bdca9L90
to
1) prepare properties in some "intermediate" form
2) apply them in one place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> update to latest dbcp and verify moving from maxActive to maxTotal
> ------------------------------------------------------------------
>
> Key: OPENJPA-2754
> URL: https://issues.apache.org/jira/browse/OPENJPA-2754
> Project: OpenJPA
> Issue Type: Task
> Components: jdbc
> Affects Versions: 3.0.0
> Reporter: Mark Struberg
> Priority: Major
> Fix For: 3.0.1
>
>
> commons-dbcp 2 moved from maxActive to maxTotal
> https://commons.apache.org/proper/commons-dbcp/
> https://commons.apache.org/proper/commons-dbcp/configuration.html
> But all across our build we still use MaxActive.
> Do we like to keep this? Do we (via reflection) don't care and users need to
> care for themselves if they switch?
> Do we do it right in our unit tests right now?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
