I'm OK with both options :) On Mon, 6 Jul 2020 at 14:43, Romain Manni-Bucau <rmannibu...@gmail.com> wrote:
> Le lun. 6 juil. 2020 à 09:33, Maxim Solodovnik <solomax...@gmail.com> a > écrit : > > > Unfortunately I was unable to create tests for my PR yet :((( > > can we merge it without tests for now? > > > > We have 2 options: > > 1. We merge it like that - there is the indexes flag anyway so impact can > be limited - and we work on a test for next release > 2. We postpone it for next release we can plan in not so long (if Mark > wants some more fixes it be worth another release soon anyway) > > The code looks ok and the few tests I did were ok but I didn't launch a > full build on this PR but if green I would be to get it in. > > > > > > And +1 to release :) > > > > On Mon, 6 Jul 2020 at 14:27, Romain Manni-Bucau <rmannibu...@gmail.com> > > wrote: > > > > > +1, dont think we should wait for features not impacting users > (thinking > > to > > > tests). > > > > > > Romain Manni-Bucau > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > <http://rmannibucau.wordpress.com> | Github < > > > https://github.com/rmannibucau> | > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > < > > > > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > > > > > Le lun. 6 juil. 2020 à 09:22, Mark Struberg <strub...@yahoo.de.invalid > > > > a > > > écrit : > > > > > > > Hi! > > > > > > > > I had plans to add a few more fixes but didn't find enough time. > Right > > > now > > > > working on improving the test suite and move it to junit4. > > > > This might still take some time. So should I better roll an openjpa > > > > release now? > > > > > > > > LieGrue, > > > > strub > > > > > > > > > > > > > > > > > -- > > Best regards, > > Maxim > > > -- Best regards, Maxim
