rmannibucau commented on a change in pull request #82:
URL: https://github.com/apache/openjpa/pull/82#discussion_r731529712
##########
File path:
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/JPAProperties.java
##########
@@ -29,6 +29,8 @@
import org.apache.openjpa.kernel.DataCacheStoreMode;
import org.apache.openjpa.lib.util.StringUtil;
+import serp.util.Strings;
Review comment:
guess if you want to reuse something StringUtil#parse is not a bad one.
open point: coercing is handled in out factory layer
(persistence.xml@properties -> instance) so it looks like the fix belongs to
org.apache.openjpa.enhance.Reflection which is where the issue can happen (ie
we set not knowing what it is setting) and not JPAProperties.
That's the two comment I see on this but I'm also fine merging as this since
it is simple enough.
Any other opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
