dazey3 commented on a change in pull request #82:
URL: https://github.com/apache/openjpa/pull/82#discussion_r731991385
##########
File path:
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/JPAProperties.java
##########
@@ -29,6 +29,8 @@
import org.apache.openjpa.kernel.DataCacheStoreMode;
import org.apache.openjpa.lib.util.StringUtil;
+import serp.util.Strings;
Review comment:
> coercing is handled in out factory layer (persistence.xml@properties
-> instance)
This path is not for persistence.xml properties; it is more directly related
to `javax.persistence.EntityManager.setProperty(String arg0, Object arg1)`
which is handled completely separately on OpenJPA from the logic that processes
persistence.xml properties. I assume this is mostly for performance reasons.
See `org.apache.openjpa.persistence.EntityManagerImpl.setProperty(String prop,
Object value)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
