cristof commented on PR #142: URL: https://github.com/apache/openjpa/pull/142#issuecomment-4372539559
> > Could you please reverse the commit [fbae29f](https://github.com/apache/openjpa/commit/fbae29f8fc1a5c68a4aa58148d1a1033a8136f18), and test again against pg before pushing it? Let's see if the change is really needed. Also, it seems the build is broken after some of the commits made today. Please check what happened and fix before pushing it. > > I just retested. Reverted [fbae29f](https://github.com/apache/openjpa/commit/fbae29f8fc1a5c68a4aa58148d1a1033a8136f18) (and the dependent [cf0166f](https://github.com/apache/openjpa/commit/cf0166feb4706f5b1b43666a57c62f8515d822cb)) on a throwaway branch and ran the full JPA 3.2 TCK against postgres:18: errors=65, completed=2135, every failure hitting the same root cause: > > ``` > ERROR: column "bytearraydata" is of type oid but expression is of type bytea > ``` > > Eight TCK classes are affected: core.annotations.lob.Client, the core.annotations.access.field/property Client suites and the core.types.field/property Client suites. Restoring the two commits brings us back to 2134/2134 passing. So the OID setBytes/getBytes overrides are required for TCK conformance on PostgreSQL. In that case, I think we should let it be. Maybe the TCK db leads to these errors. The alternative would be opening a challenge agains the TCK, but I guess they are past it (working on JPA 4 or 4.1). @tandraschko, to you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
