[ 
https://issues.apache.org/jira/browse/OPENJPA-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143582#comment-18143582
 ] 

ASF subversion and git services commented on OPENJPA-3007:
----------------------------------------------------------

Commit 31df7f3f6be8ffae26cbbd2ddee869ce77192e6d in openjpa's branch 
refs/heads/OPENJPA-3007 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=31df7f3f6 ]

[OPENJPA-3007] Close the EntityManagerFactory of TestEmbeddableCriteria in 
@AfterAll

The class counted public test* methods to decide when to close the
shared factory. After the conversion no method matches, so the factory
was rebuilt for every method. Close the EntityManager after each method
and the factory in @AfterAll, which also runs when methods are skipped.


> Junit6 should be used for tests
> -------------------------------
>
>                 Key: OPENJPA-3007
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-3007
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: build / infrastructure
>    Affects Versions: 4.1.1
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.3.0
>
>
>  - Junit6 should be used for tests
>  - various 
> {code}
>     <dependencies>
>         <dependency>
>             <groupId>junit</groupId>
>             <artifactId>junit</artifactId>
>         </dependency>
>     </dependencies>
> {code}
> blocks (added at 0e8b4abfb04d02d9bf9a862b14b8afadc88f3445) should be removed
>  - {{TestEmbeddableCriteria.countTestMethods}} need to be carefully migrated
>  - various {{assertSQL}}, {{assertNotSQL}}, {{assertAllSQL*}}, 
> {{assertSQLFragnments}} need to be unified
>  - Tests like 
> {{openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/conversion/TestConvertedInPlaceChange.java}}
>  {{testElementOfConvertedListRestoredOnRollback}} need to be converted to 
> parametrized



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to