[
https://issues.apache.org/jira/browse/OPENJPA-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18143581#comment-18143581
]
ASF subversion and git services commented on OPENJPA-3007:
----------------------------------------------------------
Commit ff6601352aa8da071a540fa46af0e78b5bdf7682 in openjpa's branch
refs/heads/OPENJPA-3007 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=ff6601352 ]
[OPENJPA-3007] Compare the SQL in every embeddable and join criteria test
EmbeddableDomainTestCase and JoinDomainTestCase set the dictionary only
in the test instance that created the shared EntityManagerFactory. Every
later instance had no dictionary, so executeAndCompareSQL skipped the
SQL comparison. Set it in every setUp(), as CriteriaTest does.
This exposes a wrong expectation in embeddableQuery76 to 83: the default
collection table of EntityA_Coll_Embed_Embed.embeds is named after the
entity (EntityA_Coll_Embed_Embed_embeds), not after its table TBL1A.
> Junit6 should be used for tests
> -------------------------------
>
> Key: OPENJPA-3007
> URL: https://issues.apache.org/jira/browse/OPENJPA-3007
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 4.1.1
> Reporter: Maxim Solodovnik
> Assignee: Maxim Solodovnik
> Priority: Major
> Fix For: 4.3.0
>
>
> - Junit6 should be used for tests
> - various
> {code}
> <dependencies>
> <dependency>
> <groupId>junit</groupId>
> <artifactId>junit</artifactId>
> </dependency>
> </dependencies>
> {code}
> blocks (added at 0e8b4abfb04d02d9bf9a862b14b8afadc88f3445) should be removed
> - {{TestEmbeddableCriteria.countTestMethods}} need to be carefully migrated
> - various {{assertSQL}}, {{assertNotSQL}}, {{assertAllSQL*}},
> {{assertSQLFragnments}} need to be unified
> - Tests like
> {{openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/conversion/TestConvertedInPlaceChange.java}}
> {{testElementOfConvertedListRestoredOnRollback}} need to be converted to
> parametrized
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)