Hi Maxim, I have gone through the changes which you have requested their. I did those changes about 3 weeks ago. I have added comment here https://issues.apache.org/jira/browse/OPENMEETINGS-558.
SIL licenses issue is OK now (Sebetian has committed the files). Also since all the UI comments are buttons, I didn't see a localization option. Sebastian has committed a early version to his repo. So I will checkout his trunk and do those modifications there and will send him a pull request. Thanks! On Mon, Jul 1, 2013 at 11:18 PM, Maxim Solodovnik <solomax...@gmail.com>wrote: > Hello Andun, > > It should be component (maybe additionally behavior, not sure) > WISIWYG is not finished yet (only first revision is committed) here is > what else need to be done: > https://groups.google.com/d/msg/wicket-jquery-ui/V1xB3fq7yT4/j2fq2LYcA2sJ > > > On Tue, Jul 2, 2013 at 12:38 AM, Andun Sameera <andun...@gmail.com> wrote: > >> Hi Maxim, >> >> >> On Mon, Jul 1, 2013 at 8:45 PM, Maxim Solodovnik <solomax...@gmail.com>wrote: >> >>> Hello Andun, >>> >>> let's start from integrating Andrey's whiteboard to sample wicket >>> application. >>> >> >> Don't we have to to create behavior or component form Andreys Whiteboard? >> I will create a application and will add it to git hub. >> >> >>> Additional work need to be done: >>> 0) WYSIWYG editor plugin should be completed in the background >>> >> >> Wysiwyg Editor implementation is finished now and committed to >> https://github.com/andunslg/Wysiwyg-Wicket. >> >> 1) all whiteboard objects need to be stored in local static Hashtable >>> on addition >>> 2) connected users should receive all objects on connection (you can >>> take a look at current OM chat for example) >>> 3) newly added WB objects should be pushed to already connected users >>> 4) WB should be modified to >>> a) have limited size (as option) >>> b) able to draw/put additional objects (to conform Flash WB) >>> >>> >>> >>> >>> On Mon, Jul 1, 2013 at 2:08 PM, Andun Sameera <andun...@gmail.com>wrote: >>> >>>> Hi Maxim, >>>> >>>> I am waiting for a decision. Can you help me, thus I can do some coding >>>> and work. >>>> >>>> Thanks! >>>> AndunSLG >>>> From my Mobile >>>> On Jun 26, 2013 11:29 PM, "Maxim Solodovnik" <solomax...@gmail.com> >>>> wrote: >>>> >>>>> Great, thanks >>>>> I believe this should be resolved by the end of the week >>>>> >>>>> >>>>> On Thu, Jun 27, 2013 at 12:55 AM, Andun Sameera <andun...@gmail.com>wrote: >>>>> >>>>>> Hi Maxim, >>>>>> >>>>>> Until this get sloved by considering GSOC proposal, timeline, the >>>>>> pros and cons which you highlighted, I will continue the exploration on >>>>>> the >>>>>> given WB code! >>>>>> >>>>>> Thanks! >>>>>> >>>>>> >>>>>> On Wed, Jun 26, 2013 at 11:16 PM, Maxim Solodovnik < >>>>>> solomax...@gmail.com> wrote: >>>>>> >>>>>>> Hello Andun, Andrey, All, >>>>>>> >>>>>>> sorry for the late response, I was on vacation with very few >>>>>>> internet access. >>>>>>> >>>>>>> The main pros of Andrei's whiteboard are: >>>>>>> 1) it is implemented and working >>>>>>> 2) we know the person who is expect in it >>>>>>> >>>>>>> cons are: >>>>>>> 1) this WB is endless (this can easily be workarounded by "go to >>>>>>> center" + zoom feature) >>>>>>> >>>>>>> Additionally I have following concern regarding splitting this task >>>>>>> between Andun and Alexei since the value of Andun work we be less after >>>>>>> such splitting :( >>>>>>> >>>>>>> @Alexei, @Sebastian, @dev can you please suggest any option how this >>>>>>> can be resolved, or maybe it not an issue and the task can be split >>>>>>> easily? >>>>>>> >>>>>>> >>>>>>> I hopefully will be able to work on 3.0 in couple of nearest days >>>>>>> >>>>>>> Thanks in advance >>>>>>> >>>>>>> >>>>>>> On Sat, Jun 22, 2013 at 10:43 PM, Andun Sameera >>>>>>> <andun...@gmail.com>wrote: >>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> On Mon, Jun 17, 2013 at 7:56 PM, Bogdanov Andrey <ba...@mail.ru>wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> > While knowing that, I think both of us needs comments from devs >>>>>>>>> about >>>>>>>>> > future works. >>>>>>>>> I think it's a key point. I'm also new in the OM community and >>>>>>>>> can't make a decision. >>>>>>>>> >>>>>>>>> About technical details: >>>>>>>>> 1. Whiteboard could be included as js-file, css-file and few >>>>>>>>> images. I'm not familiar with Wickets, but sure it's not a problem to >>>>>>>>> do >>>>>>>>> this. >>>>>>>>> >>>>>>>> >>>>>>>> Yes we can include it by creating a wicket component + a behavior. >>>>>>>> >>>>>>>> 2. There is a way to attach js-function as event listener for >>>>>>>>> onChange event. There is not separate event for each type of drawing >>>>>>>>> element, but element is passed as a parameter to onChange event. Now >>>>>>>> >>>>>>>> 3. There is a method to serialize all WB contant as json string and >>>>>>>>> WB can be restored from this string. It could be use for saving. >>>>>>>>> >>>>>>>> >>>>>>>> Great! So I will find a way to get those function related JSON >>>>>>>> data to wicket environment! Using those data we can synch the >>>>>>>> whiteboards! >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Andrey >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Понедельник, 17 июня 2013, 0:09 +05:30 от Andun Sameera < >>>>>>>>> andun...@gmail.com>: >>>>>>>>> >Hi, >>>>>>>>> > >>>>>>>>> >According to my background study of GSOC proposal, we have >>>>>>>>> following >>>>>>>>> >functionality in the whiteboard, >>>>>>>>> > >>>>>>>>> > - Draw simple shapes >>>>>>>>> > - Type text >>>>>>>>> > - Add images to the whiteboard >>>>>>>>> > - Add documents like doc, docx, odt, pdf to the whiteboard >>>>>>>>> > - Save content of whiteboard >>>>>>>>> > >>>>>>>>> >But our first target was to implement 1st and 2nd with the proven >>>>>>>>> >feasibility of implementing the rest. We had these agreements >>>>>>>>> about >>>>>>>>> >implementing the whiteboard, >>>>>>>>> > >>>>>>>>> > - It should be a Apache Wicket Module which can be reused in >>>>>>>>> any where >>>>>>>>> > which have a requirement of a whiteboard. >>>>>>>>> > - The drawings, typing, doc sharing have to be synchronized >>>>>>>>> with all the >>>>>>>>> > viewers of the whiteboard. To do that what Maxim suggested was >>>>>>>>> this, >>>>>>>>> > - At the end of each drawing typing, changing, moving etc. >>>>>>>>> an event >>>>>>>>> > is triggered. Say a method call. >>>>>>>>> > - That will call the backend and the synchronization logic. >>>>>>>>> > - The example which Maxim gave was this, >>>>>>>>> > >>>>>>>>> >Whiteboard w = new Whiteboard("wb") { >>>>>>>>> > public onCircle(CircleEvent evt, AjaxRequestTarget target) { >>>>>>>>> > //handle circle creation here >>>>>>>>> > } >>>>>>>>> > >>>>>>>>> >....... etc. >>>>>>>>> > >>>>>>>>> >} >>>>>>>>> > >>>>>>>>> >According to my mind, we have the feasibility of implementing >>>>>>>>> advanced >>>>>>>>> >features of WB with Closure. Now what we have to do is converting >>>>>>>>> the >>>>>>>>> >whiteboard to a Wicket Module which will have methods like above >>>>>>>>> which can >>>>>>>>> >be used to invoke the synchronization logic. >>>>>>>>> > >>>>>>>>> >While knowing that, I think both of us needs comments from devs >>>>>>>>> about >>>>>>>>> >future works. >>>>>>>>> > >>>>>>>>> >Thanks! >>>>>>>>> > >>>>>>>>> >On Sun, Jun 16, 2013 at 11:14 PM, Bogdanov Andrey < ba...@mail.ru> >>>>>>>>> >wrote: >>>>>>>>> > >>>>>>>>> >> Hi Andun, >>>>>>>>> >> >>>>>>>>> >> At first I completely agree with your comparison af Closure and >>>>>>>>> RaphaelJS. >>>>>>>>> >> Closure is not the best tool for drawing, but it privides a lot >>>>>>>>> of >>>>>>>>> >> additional facilities for building of UI. After jQuery it looks >>>>>>>>> >> slightly tedious, but allows manage code very well. >>>>>>>>> >> >>>>>>>>> >> As I mentioned before I didn't think about OM whiteboard when >>>>>>>>> creating my. >>>>>>>>> >> So some functionality is missing there. But I think it could be >>>>>>>>> easily >>>>>>>>> >> implemented. If there are some definite features which need to >>>>>>>>> be >>>>>>>>> >> implemented I can do it. The main problem for me right now - >>>>>>>>> how to include >>>>>>>>> >> the whiteboard to existing project. >>>>>>>>> >> >>>>>>>>> >> Regards, >>>>>>>>> >> Andrey Bogdanov >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> Воскресенье, 16 июня 2013, 19:32 +05:30 от Andun Sameera < >>>>>>>>> >> andun...@gmail.com >: >>>>>>>>> >> >>>>>>>>> >> Hi All, >>>>>>>>> >> >>>>>>>>> >> As Maxim requested I have looked at both Google Closure and >>>>>>>>> KineticJS. >>>>>>>>> >> >>>>>>>>> >> *Google Closure * *Kinectic JS, RaphaelJS* Well maintained >>>>>>>>> Well >>>>>>>>> >> maintained Good Tutorials, Support Good Tutorials, Support >>>>>>>>> Feature >>>>>>>>> >> Full, Can Create Complete Uis like GMail Specific for tasks >>>>>>>>> like Drawing, >>>>>>>>> >> Animations. Facilitate enough features for that. Hard to >>>>>>>>> learn,manage Easy >>>>>>>>> >> to learn,mange >>>>>>>>> >> As Maxim highlighted, there is no specific reason for me to >>>>>>>>> leave Closure >>>>>>>>> >> behind. But in Andrey's whiteboard we have lot of features than >>>>>>>>> current OM >>>>>>>>> >> WB. Thus what we can do is, >>>>>>>>> >> >>>>>>>>> >> - We can customize it to match with current WB >>>>>>>>> >> - we can improve WB to have all these functionality in >>>>>>>>> Andrey's >>>>>>>>> >> whiteboard. >>>>>>>>> >> >>>>>>>>> >> I need comments for that choice. >>>>>>>>> >> >>>>>>>>> >> I think we have to use a separate synchronization logic with >>>>>>>>> Wickets other >>>>>>>>> >> than the web socket synchronization. Also if Andrey's >>>>>>>>> whiteboard is matured >>>>>>>>> >> enough for use in OM, I can start the work of creating a Wicket >>>>>>>>> Module for >>>>>>>>> >> that a we planned in the GSOC proposal. >>>>>>>>> >> >>>>>>>>> >> Thanks! >>>>>>>>> >> >>>>>>>>> >> [1] - http://raphaeljs.com/ >>>>>>>>> >> [2] - http://kineticjs.com/ >>>>>>>>> >> >>>>>>>>> >> On Tue, Jun 11, 2013 at 12:49 PM, Maxim Solodovnik < >>>>>>>>> solomax...@gmail.com< >>>>>>>>> https://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com > >>>>>>>>> >> > wrote: >>>>>>>>> >> >>>>>>>>> >> Hello Andun, >>>>>>>>> >> >>>>>>>>> >> sorry for the late response >>>>>>>>> >> It is really hard to make a decision in this case >>>>>>>>> >> >>>>>>>>> >> It is really hard to refuse working contribution, plus I don't >>>>>>>>> want to >>>>>>>>> >> have more than 1 JS library doing the same :( >>>>>>>>> >> So I think we should stay on closure if there is no strong >>>>>>>>> disadvantages. >>>>>>>>> >> >>>>>>>>> >> So I would say if your investigation will show >>>>>>>>> >> 1) JS library B is better maintained >>>>>>>>> >> 2) has stronger comunity >>>>>>>>> >> 3) is better integrated with jQuery >>>>>>>>> >> ..... etc. >>>>>>>>> >> >>>>>>>>> >> we will need to choose another library as base library for your >>>>>>>>> project. >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> Current WB proposed by Andrey has different functionality than >>>>>>>>> current OM >>>>>>>>> >> WB. >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> On Sat, Jun 8, 2013 at 6:14 PM, Andun Sameera < >>>>>>>>> andun...@gmail.com< >>>>>>>>> https://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com > >>>>>>>>> >> > wrote: >>>>>>>>> >> >>>>>>>>> >> Hi Maxim, >>>>>>>>> >> >>>>>>>>> >> I have checked the working prototype which was submitted. It >>>>>>>>> has many >>>>>>>>> >> functionality implemented. While knowing that, I will compare >>>>>>>>> the >>>>>>>>> >> libraries. After that from what I should make the prototype? >>>>>>>>> From the one >>>>>>>>> >> which we have more advantages? Or do I need to implement a >>>>>>>>> prototype in >>>>>>>>> >> kinteticjs or raphaeljs to compare it with the closure one? >>>>>>>>> >> >>>>>>>>> >> Thanks! >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> On Sat, Jun 8, 2013 at 12:16 AM, Maxim Solodovnik < >>>>>>>>> solomax...@gmail.com< >>>>>>>>> https://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com > >>>>>>>>> >> > wrote: >>>>>>>>> >> >>>>>>>>> >> Why I'm asking is: >>>>>>>>> >> we already have working prototype contributed >>>>>>>>> >> it is written using "google closure" (it is not fully >>>>>>>>> synchronized, but >>>>>>>>> >> able to draw) >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> On Sat, Jun 8, 2013 at 1:42 AM, Andun Sameera < >>>>>>>>> andun...@gmail.com< >>>>>>>>> https://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com > >>>>>>>>> >> > wrote: >>>>>>>>> >> >>>>>>>>> >> OK Maxim. Also I was planning to use kineticJS to implement >>>>>>>>> whiteboard. >>>>>>>>> >> Will list all pros and cons for that also. >>>>>>>>> >> >>>>>>>>> >> Thanks! >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> On Sat, Jun 8, 2013 at 12:09 AM, Maxim Solodovnik < >>>>>>>>> solomax...@gmail.com< >>>>>>>>> https://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com > >>>>>>>>> >> > wrote: >>>>>>>>> >> >>>>>>>>> >> Hello Andun, >>>>>>>>> >> >>>>>>>>> >> I'll be on vacation with limited or no internet connection >>>>>>>>> >> 2013.06.12-2013.06.25 >>>>>>>>> >> Please do the following >>>>>>>>> >> >>>>>>>>> >> 1) Take a look at this whiteboard prototype: >>>>>>>>> >> https://issues.apache.org/jira/browse/OPENMEETINGS-662 >>>>>>>>> >> I need you to: >>>>>>>>> >> >>>>>>>>> >> 1. provide pros and contras of using rafael.js VS "google >>>>>>>>> closure" to >>>>>>>>> >> implement whiteboard >>>>>>>>> >> 2. start prototyping WB without messages exchange >>>>>>>>> >> >>>>>>>>> >> 2) Finish WYSIWYG plugin, I believe it can be used as >>>>>>>>> deliverable in GSOC. >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> Please contact dev list while my vacation. >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> WBR >>>>>>>>> >> Maxim aka solomax >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> Regards >>>>>>>>> >> Andun S.L. Gunawardana >>>>>>>>> >> Undergraduate >>>>>>>>> >> Department of Computer Science And Engineering >>>>>>>>> >> University of Moratuwa >>>>>>>>> >> Sri Lanka >>>>>>>>> >> >>>>>>>>> >> Blog - http://www.insightforfuture.blogspot.com/ >>>>>>>>> >> LinkedIn - >>>>>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>>>>> >> Twitter - http://twitter.com/AndunSLG >>>>>>>>> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> WBR >>>>>>>>> >> Maxim aka solomax >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> Regards >>>>>>>>> >> Andun S.L. Gunawardana >>>>>>>>> >> Undergraduate >>>>>>>>> >> Department of Computer Science And Engineering >>>>>>>>> >> University of Moratuwa >>>>>>>>> >> Sri Lanka >>>>>>>>> >> >>>>>>>>> >> Blog - http://www.insightforfuture.blogspot.com/ >>>>>>>>> >> LinkedIn - >>>>>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>>>>> >> Twitter - http://twitter.com/AndunSLG >>>>>>>>> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> WBR >>>>>>>>> >> Maxim aka solomax >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> Regards >>>>>>>>> >> Andun S.L. Gunawardana >>>>>>>>> >> Undergraduate >>>>>>>>> >> Department of Computer Science And Engineering >>>>>>>>> >> University of Moratuwa >>>>>>>>> >> Sri Lanka >>>>>>>>> >> >>>>>>>>> >> Blog - http://www.insightforfuture.blogspot.com/ >>>>>>>>> >> LinkedIn - >>>>>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>>>>> >> Twitter - http://twitter.com/AndunSLG >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> -- >>>>>>>>> >> Андрей Богданов >>>>>>>>> >> >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> >-- >>>>>>>>> >Regards >>>>>>>>> >Andun S.L. Gunawardana >>>>>>>>> >Undergraduate >>>>>>>>> >Department of Computer Science And Engineering >>>>>>>>> >University of Moratuwa >>>>>>>>> >Sri Lanka >>>>>>>>> > >>>>>>>>> >Blog - http://www.insightforfuture.blogspot.com/ >>>>>>>>> >LinkedIn - >>>>>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>>>>> >Twitter - http://twitter.com/AndunSLG >>>>>>>>> > >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Андрей Богданов >>>>>>>>> >>>>>>>> >>>>>>>> Thanks! >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Regards >>>>>>>> Andun S.L. Gunawardana >>>>>>>> Undergraduate >>>>>>>> Department of Computer Science And Engineering >>>>>>>> University of Moratuwa >>>>>>>> Sri Lanka >>>>>>>> >>>>>>>> Blog - http://www.insightforfuture.blogspot.com/ >>>>>>>> LinkedIn - >>>>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>>>> Twitter -http://twitter.com/AndunSLG >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> WBR >>>>>>> Maxim aka solomax >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards >>>>>> Andun S.L. Gunawardana >>>>>> Undergraduate >>>>>> Department of Computer Science And Engineering >>>>>> University of Moratuwa >>>>>> Sri Lanka >>>>>> >>>>>> Blog - http://www.insightforfuture.blogspot.com/ >>>>>> LinkedIn - >>>>>> http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >>>>>> Twitter -http://twitter.com/AndunSLG >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> WBR >>>>> Maxim aka solomax >>>>> >>>> >>> >>> >>> -- >>> WBR >>> Maxim aka solomax >>> >> >> Thanks! >> >> -- >> Regards >> Andun S.L. Gunawardana >> Undergraduate >> Department of Computer Science And Engineering >> University of Moratuwa >> Sri Lanka >> >> Blog - http://www.insightforfuture.blogspot.com/ >> LinkedIn - http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 >> Twitter -http://twitter.com/AndunSLG >> >> >> >> >> > > > > -- > WBR > Maxim aka solomax > -- Regards Andun S.L. Gunawardana Undergraduate Department of Computer Science And Engineering University of Moratuwa Sri Lanka Blog - http://www.insightforfuture.blogspot.com/ LinkedIn - http://www.linkedin.com/pub/andun-s-l-gunawardana/34/646/703 Twitter -http://twitter.com/AndunSLG
