solomax commented on a change in pull request #65:
URL: https://github.com/apache/openmeetings/pull/65#discussion_r414872263
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
##########
@@ -373,6 +373,8 @@ private void stopSharing(Client c, String uid) {
StreamDesc sd = doStopSharing(c.getSid(), uid);
if (sender != null && sd != null) {
sender.stopBroadcast(this);
+ } else {
Review comment:
this usually happens on `double-stop` are you sure it will produce
ghosts?
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
##########
@@ -384,17 +386,26 @@ public void connected() {
notifyRooms();
}
}
+
+ private class KWatchDogDestroy implements
EventListener<ObjectDestroyedEvent> {
Review comment:
This one seems to be `LogDog` :)))
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
##########
@@ -237,7 +237,7 @@ public void startSharing(StreamProcessor processor,
IClientManager cm, Client c,
sd = c.addStream(StreamType.SCREEN, a);
sd.setWidth(msg.getInt("width")).setHeight(msg.getInt("height"));
cm.update(c);
- log.debug("User {}: has started sharing", sd.getUid());
+ log.debug("User {}: has started sharing, with stream:
{}", sd.getUid(), a);
Review comment:
I Would change this message to be `Stream {}: sharing has been started,
activity: {}`
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
##########
@@ -431,6 +433,10 @@ public void stopRecording(Client c) {
return;
}
kHandler.getRoom(c.getRoomId()).stopRecording(this, c);
+ Optional<StreamDesc> osd = c.getScreenStream();
Review comment:
I would write it using modern syntax:
```
c.getScreenStream().ifPresent(sd -> {
if (!sd.hasActivity(Activity.SCREEN)) {
pauseSharing(c, sd.getUid());
}
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
