sebawagner commented on a change in pull request #65:
URL: https://github.com/apache/openmeetings/pull/65#discussion_r415148044



##########
File path: 
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
##########
@@ -373,6 +373,8 @@ private void stopSharing(Client c, String uid) {
                StreamDesc sd = doStopSharing(c.getSid(), uid);
                if (sender != null && sd != null) {
                        sender.stopBroadcast(this);
+               } else {

Review comment:
       The stop doesn't directly. But it does indirectly. Cause when its 
stopped like that on startingRecording again, some stream object isn't 100% 
cleared. Which then leads to a ghost KStream and a failed restart of the 
recording.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to