sebawagner commented on a change in pull request #111:
URL: https://github.com/apache/openmeetings/pull/111#discussion_r487744308
##########
File path:
openmeetings-util/src/main/java/org/apache/openmeetings/util/OmFileHelper.java
##########
@@ -104,6 +104,7 @@ public static void setOmHome(File home) {
if (Strings.isEmpty(dataDir)) {
DATA_HOME = new File(OM_HOME, DATA_DIR);
} else {
+ log.info("Overwrite custom DATA_DIR: {}", dataDir);
Review comment:
What is wrong with ENV variable?
* It would be better to have a central/single way of configuring, we
splitting some in XML files others in System.getProperty
* If you run multiple openmeetings webapps in same container you can't
configure individual params
* Env variables are more for usage in shell scripts
* Env variables make it hard to create unit and integration tests that run
on automated environments
Some of those :) :( :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
